Skip to content

feat(material-experimental/selection): Add Material version for cdk-experimental/selection #18620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

feat(material-experimental/selection): Add Material version for cdk-experimental/selection #18620

merged 1 commit into from
Mar 31, 2020

Conversation

yifange
Copy link
Contributor

@yifange yifange commented Feb 26, 2020 •
edited
Loading

Add Material directives and components that make adding selection state to a list of items easier.

  • MatSelection: "mat-" alias of CdkSelection
  • MatSelectionToggle: "mat-" alias of CdkSelectionToggle
  • MatSelectAll: "mat-" alias of CdkSelectAll
  • MatRowSelection: "mat-" alias of CdkRowSelection
  • MatSelectionColumn: Similar to CdkSelectionColumn. Use <mat-checkbox> instead of native <input>.

Issue #18581

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2020
@yifange yifange force-pushed the mat-aliases branch 3 times, most recently from 371cd30 to 710c6aa Compare February 26, 2020 02:01
@yifange yifange marked this pull request as ready for review February 26, 2020 04:27
@yifange yifange requested review from andrewseguin, jelbourn and a team as code owners February 26, 2020 04:27
jelbourn
jelbourn reviewed Mar 3, 2020
View reviewed changes
jelbourn
jelbourn reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header checkbox still looks a bit off:
image

andrewseguin
andrewseguin reviewed Mar 5, 2020
View reviewed changes
@yifange yifange force-pushed the mat-aliases branch 2 times, most recently from b43480e to 053b6a2 Compare March 13, 2020 05:14
@yifange
Copy link
Contributor Author

yifange commented Mar 17, 2020

image
The checkbox in the header should look all right now.

@jelbourn jelbourn added G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Mar 30, 2020
jelbourn
jelbourn approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 30, 2020
@jelbourn jelbourn merged commit 95b51e7 into angular:cdk-selection Mar 31, 2020
@yifange yifange deleted the mat-aliases branch April 10, 2020 22:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifange @jelbourn @andrewseguin @googlebot