fix(list): no disabled indication in high contrast mode #18567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes not being able to distinguish disabled list items in high contrast mode.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 20, 2020
| // Since we can't use a color to indicate that the list | ||
| // item is disabled, we have to use opacity instead. | ||
| @include cdk-high-contrast { | ||
| opacity: 0.5; |
There was a problem hiding this comment.
What does the contrast ratio end up being with this?
There was a problem hiding this comment.
I haven't measured it, but this isn't the first place where we indicate disabled elements by reducing the opacity to 0.5.
andrewseguin
pushed a commit
that referenced
this pull request
Mar 12, 2020
Fixes not being able to distinguish disabled list items in high contrast mode. (cherry picked from commit ea03cce)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to distinguish disabled list items in high contrast mode.