-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental): rename theme files to match stable components #18383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the CI issues are resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Way more consistent now 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1119960
to
fcaddb9
Compare
I think this PR needs a rebase. Would it make sense to prioritize that PR so that it doesn't get out of sync again? I'd also prefer to have this merged so that I can base my density PR on it. |
fcaddb9
to
10cb5a9
Compare
10cb5a9
to
555f333
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Renames theme files so that
_mdc
-theme.scss
I'm not sure why they started with the mdc prefix, there doesn't seem to be a reason for it so I'm removing it. Primary motivation was to suffix all theme files with "-theme"
CARETAKER NOTE: This may require some BUILD rule changes internally