-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor: rename nav
schematic to navigation
#18364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename nav
schematic to navigation
#18364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some initial misgivings with this approach, but it does seem to better align with our overall schematic naming scheme. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be a breaking change for anyone referencing nav in blog posts or videos?
@IgorMinar I made it so that |
@devversion Ok that sound great! |
Our docs often describe the `nav` schematic as `navigation` schematics, and it's not quite clear what the actual schematic name is. To avoid this confusion, we just name it `navigation`, but keep support for the old `nav` abbreviation.
472c3d3
to
9a8f13c
Compare
Our docs often describe the `nav` schematic as `navigation` schematics, and it's not quite clear what the actual schematic name is. To avoid this confusion, we just name it `navigation`, but keep support for the old `nav` abbreviation.
Our docs often describe the `nav` schematic as `navigation` schematics, and it's not quite clear what the actual schematic name is. To avoid this confusion, we just name it `navigation`, but keep support for the old `nav` abbreviation.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Our docs often describe the
nav
schematic asnavigation
schematics,and it's not quite clear what the actual schematic name is. To avoid
this confusion, we just name it
navigation
, but keep support forthe old
nav
abbreviation.