Skip to content

build: minor improvements to testing script #18363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 1, 2020

  • Currently the test script doesn't support doing something like yarn test material/stepper, instead we have to pass in src/material/stepper explicitly. These changes make it so that we don't have to pass in src, because it's easy to forget.
  • Makes it so we exit the process, rather than throw an error when a target isn't found. This makes it easier to locate the error message since there won't be a large stack trace moving it up.

* Currently the test script doesn't support doing something like `yarn test material/stepper`, instead we have to pass in `src/material/stepper` explicitly. These changes make it so that we don't have to pass in `src`, because it's easy to forget.
* Makes it so we exit the process, rather than throw an error when a target isn't found. This makes it easier to locate the error message since there won't be a large stack trace moving it up.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 1, 2020
@crisbeto crisbeto requested a review from a team as a code owner February 1, 2020 16:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 1, 2020
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 1, 2020
@mmalerba mmalerba merged commit 2fc488c into angular:master Feb 4, 2020
yifange pushed a commit to yifange/components that referenced this pull request Feb 6, 2020
* Currently the test script doesn't support doing something like `yarn test material/stepper`, instead we have to pass in `src/material/stepper` explicitly. These changes make it so that we don't have to pass in `src`, because it's easy to forget.
* Makes it so we exit the process, rather than throw an error when a target isn't found. This makes it easier to locate the error message since there won't be a large stack trace moving it up.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants