fix(a11y): avoid errors when trying to add high contrast class #18323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
Found this in some errors logs. The `document.defaultView` can be null in some cases which causes a null pointer error to be thrown. Furthermore, these changes add a few more null checks to ensure that we don't throw if `getComputedStyle` isn't available.
crisbeto
force-pushed
the
high-contrast-null-checks
branch
from
98e3419 to
efcf96a
Compare
devversion
approved these changes
Jan 29, 2020
mmalerba
pushed a commit
that referenced
this pull request
Apr 14, 2020
Found this in some errors logs. The `document.defaultView` can be null in some cases which causes a null pointer error to be thrown. Furthermore, these changes add a few more null checks to ensure that we don't throw if `getComputedStyle` isn't available.
This was referenced May 3, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this in some errors logs. The
document.defaultViewcan be null in some cases which causes a null pointer error to be thrown. Furthermore, these changes add a few more null checks to ensure that we don't throw ifgetComputedStyleisn't available.Note: setting this as a P2, because we run this logic during bootstrap as a part of the
MatCommonModulewhich can cause the entire app to break down.