Skip to content

docs(drag-drop): add last star wars movie in examples #18319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

docs(drag-drop): add last star wars movie in examples #18319

merged 1 commit into from
Jan 28, 2020

Conversation

marc-x-andre
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 28, 2020
jelbourn
jelbourn approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Making the important fixes.

@jelbourn jelbourn added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 28, 2020
@jelbourn jelbourn merged commit 96f1625 into angular:master Jan 28, 2020
@marc-x-andre marc-x-andre deleted the new-star-wars-movie branch January 28, 2020 23:08
@crisbeto
Copy link
Member

crisbeto commented Jan 29, 2020 •
edited
Loading

Now we need a design doc on whether they should be ordered chronologically, in release order, or in the Machete order.

yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@marc-x-andre @yifange
docs(drag-drop): add last star wars movie in examples (angular#18319)
f5082e5
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-x-andre @crisbeto @jelbourn @googlebot