Skip to content

fix(material/icon/testing): Adds size specs to fake icon #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

fix(material/icon/testing): Adds size specs to fake icon #18306

merged 1 commit into from
Jan 29, 2020

Conversation

osuritz
Copy link
Contributor

@osuritz osuritz commented Jan 27, 2020

Adds size specs to the fake icon to match specs of the real implementation.
Without this, the rendered blank icon has the default size of an SVG element
which is 300x150px which can break layouts.

@osuritz
fix(material/icon/testing): Adds size specs to fake icon
8e00f90 
Adds size specs to the fake icon to match specs of the real implementation.
Without this, the rendered blank icon has the default size of an SVG element
which is 300x150px which can break layouts.
@osuritz osuritz requested a review from jelbourn as a code owner January 27, 2020 22:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 27, 2020
jelbourn
jelbourn approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added G This is is related to a Google internal issue pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 27, 2020
@jelbourn jelbourn merged commit 27ef842 into angular:master Jan 29, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@osuritz @yifange
fix(material/icon/testing): Adds size specs to fake icon (angular#18306)
b7d668b 
Adds size specs to the fake icon to match specs of the real implementation.
Without this, the rendered blank icon has the default size of an SVG element
which is 300x150px which can break layouts.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osuritz @jelbourn @googlebot