fix(slide-toggle): clicks not landing correctly in some cases on Chrome #18285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
changed the title
Any time the slide toggle host receives focus we forward it immediately to the underlying `input` element. This bouncing around of focus seems to interrupt click events in some cases on Chrome. These changes make it so that we only forward focus for events originating from the keyboard or programmatically. Fixes angular#18269.
crisbeto
force-pushed
the
18269/slide-toggle-click
branch
from
e52a847 to
c454df5
Compare
devversion
approved these changes
Jan 27, 2020
| // 1. It can prevent clicks from landing in Chrome (see #18269). | ||
| // 2. They're already handled by the wrapping `label` element. | ||
| if (focusOrigin === 'keyboard' || focusOrigin === 'program') { | ||
| this._inputElement.nativeElement.focus(); |
There was a problem hiding this comment.
Related to that, did we consider forwarding the focus origin here? (through focusVia)?
There was a problem hiding this comment.
I don't mind changing it if you feel strongly about it. I didn't do it, because there's nothing reacting to different focus origins on the input anyway so it seemed redundant.
There was a problem hiding this comment.
Yeah, it was mostly for sanity. I don't feel strongly about it. Let's just leave it as is.
devversion
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…me (angular#18285) Any time the slide toggle host receives focus we forward it immediately to the underlying `input` element. This bouncing around of focus seems to interrupt click events in some cases on Chrome. These changes make it so that we only forward focus for events originating from the keyboard or programmatically. Fixes angular#18269.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 31, 2020
This is along the same lines as angular#18285 since the radio button and slide toggle have a very similar setup. Whenever the radio button host receives focus we forward it immediately to the underlying input, but this bouncing around of focus could cause clicks to be interrupted in some cases. These changes make it so that we only move focus if the host was focused by the keyboard or mouse.
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2020
This is along the same lines as #18285 since the radio button and slide toggle have a very similar setup. Whenever the radio button host receives focus we forward it immediately to the underlying input, but this bouncing around of focus could cause clicks to be interrupted in some cases. These changes make it so that we only move focus if the host was focused by the keyboard or mouse.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time the slide toggle host receives focus we forward it immediately to the underlying
inputelement. This bouncing around of focus seems to interrupt click events in some cases on Chrome. These changes make it so that we only forward focus for events originating from the keyboard or programmatically.Fixes #18269.