Skip to content

refactor: clean up typescript 3.7 workarounds #18259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

refactor: clean up typescript 3.7 workarounds #18259

merged 1 commit into from
Jan 24, 2020

Conversation

crisbeto
Copy link
Member

Removes some workarounds that were in place before we could update to TS 3.7.

@crisbeto
refactor: clean up typescript 3.7 workarounds
69764dc 
Removes some workarounds that were in place before we could update to TS 3.7.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Jan 22, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 22, 2020
jelbourn
jelbourn approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 22, 2020
@jelbourn jelbourn merged commit 44c1a11 into angular:master Jan 24, 2020
jelbourn pushed a commit that referenced this pull request Jan 24, 2020
@crisbeto @jelbourn
refactor: clean up typescript 3.7 workarounds (#18259)
0829d96 
Removes some workarounds that were in place before we could update to TS 3.7.

(cherry picked from commit 44c1a11)
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
refactor: clean up typescript 3.7 workarounds (angular#18259)
b5fb674 
Removes some workarounds that were in place before we could update to TS 3.7.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot