Skip to content

build: allow force overriding of publish branch #18238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2020
Merged

build: allow force overriding of publish branch #18238

merged 2 commits into from
Jan 22, 2020

Conversation

devversion
Copy link
Member

  • Allows forcibly overriding of the publish branch when staging/publishing a release.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 21, 2020
@devversion devversion requested a review from a team as a code owner January 21, 2020 11:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2020
josephperrott
josephperrott approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one change

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jan 21, 2020
@jelbourn jelbourn merged commit e51f80d into angular:master Jan 22, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: allow force overriding of expected publish branch (angular#18238)
0a6d9a2
jelbourn pushed a commit that referenced this pull request Jan 30, 2020
@devversion @jelbourn
build: allow force overriding of expected publish branch (#18238)
deea0ca 
(cherry picked from commit e51f80d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @josephperrott @jelbourn @googlebot @andrewseguin