Skip to content

feat(material-experimental/mdc-input): add test harness #18224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2020
Merged

feat(material-experimental/mdc-input): add test harness #18224

merged 3 commits into from
Jan 23, 2020

Conversation

devversion
Copy link
Member

  • Adds a test harness for the MDC-based input.

@devversion devversion added pr: merge safe target: minor This PR is targeted for the next minor release labels Jan 20, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2020
mmalerba
mmalerba reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the decision on the other PR about whether to include native select

@devversion devversion force-pushed the feat/test-harness-mdc-input branch from 75e52e1 to 6fd3917 Compare January 23, 2020 09:07
@devversion
Copy link
Member Author

Updated this PR to match what we discussed in #18221. Should be good for another round of review.

mmalerba
mmalerba reviewed Jan 23, 2020
View reviewed changes
@devversion devversion force-pushed the feat/test-harness-mdc-input branch from c127b4c to f13fa30 Compare January 23, 2020 20:20
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 23, 2020
@jelbourn jelbourn merged commit c07ec04 into angular:master Jan 23, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
feat(material-experimental/mdc-input): add test harness (angular#18224)
0da7fc8
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @mmalerba @jelbourn @googlebot