-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(material/form-field): allow AbstractControlDirective as MatFormFieldControl.ngControl #18206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(material/form-field): allow AbstractControlDirective as MatFormFieldControl.ngControl #18206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some build error
286d3b5
to
38b62fb
Compare
The build error should be resolved now. I forgot to update the MDC text field. |
f4c62f6
to
ac8eae8
Compare
@crisbeto this looks like a breaking change.
|
ac8eae8
to
692dfd0
Compare
@jelbourn I've changed the type to be less break-ey. Can we do another run? |
I suspect that its just going to complain that |
Yep
|
692dfd0
to
bff7b4b
Compare
bff7b4b
to
924edd4
Compare
924edd4
to
4a9b5f8
Compare
4a9b5f8
to
f22c92a
Compare
f22c92a
to
0271043
Compare
…ormFieldControl.ngControl Allows for an `AbstractControlDirective` to be passed in as the `MatFormFieldControl.ngControl`. The advantage of passing in the abstract control directive is that it allows both form controls and form groups. This is necessary for the date range picker.
0271043
to
8145d89
Compare
…ormFieldControl.ngControl (angular#18206) Allows for an `AbstractControlDirective` to be passed in as the `MatFormFieldControl.ngControl`. The advantage of passing in the abstract control directive is that it allows both form controls and form groups. This is necessary for the date range picker.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for an
AbstractControlDirective
to be passed in as theMatFormFieldControl.ngControl
. The advantage of passing in the abstract control directive is that it allows both form controls and form groups. This is necessary for the date range picker.