feat(material-experimental/mdc-form-field): add test harness #18165
Conversation
devversion
requested review from
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
| providers: [MAT_SELECT_SCROLL_STRATEGY_PROVIDER] | ||
| }) | ||
| export class SelectWithoutFormFieldModule { | ||
| } |
There was a problem hiding this comment.
I'm not sure about this. It seem reasonable for now, but long-term that might be just the MDC based select module
| async hasFloatingLabel(): Promise<boolean> { | ||
| return (await this.host()).hasClass('mat-form-field-can-float'); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm proposing that we remove this method. It will only make sense in the non-MDC based form-field where floatLabel = never in the legacy appearance is supported. Not even adding it as part of the first stable release, will avoid a breaking change.
There was a problem hiding this comment.
It's not used in Google presently
devversion
force-pushed
the
feat/mdc-form-field-harness
branch
from
99b1f57 to
d0ad251
Compare
| async hasFloatingLabel(): Promise<boolean> { | ||
| return (await this.host()).hasClass('mat-form-field-can-float'); | ||
| } | ||
|
|
There was a problem hiding this comment.
It's not used in Google presently
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
feat/mdc-form-field-harness
branch
from
d0ad251 to
58993ef
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a new test harness for the MDC-based form-field.