build: do not build unnecessary build targets in bazel test jobs #18158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in Bazel test jobs we simply use `//src/...`. This results in non-test targets which are simply unnecessary (e.g. npm_packages), being built. Instead, we can specify `--build_tests_only` to instruct bazel to only build targets needed for testing. We verify our build in a separate `bazel_build` job, so building unrelated things in every test job is superfluos.
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
|
Note: I think it's okay to repeat this flag where needed. We don't want to add this as the default, as using this flag only makes sense in certain contexts (or in this case: CI jobs) |
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ular#18158) Currently in Bazel test jobs we simply use `//src/...`. This results in non-test targets which are simply unnecessary (e.g. npm_packages), being built. Instead, we can specify `--build_tests_only` to instruct bazel to only build targets needed for testing. We verify our build in a separate `bazel_build` job, so building unrelated things in every test job is superfluos.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Bazel test jobs we simply use
//src/.... This resultsin non-test targets which are simply unnecessary (e.g. npm_packages),
being built. Instead, we can specify
--build_tests_onlyto instructbazel to only build targets needed for testing.
We verify our build in a separate
bazel_buildjob, so buildingunrelated things in every test job is superfluos.