Skip to content

build: bump Angular dependencies to latest versions #18137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

build: bump Angular dependencies to latest versions #18137

merged 1 commit into from
Jan 9, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 9, 2020

Bumps the Angular-related dependencies to their latest versions.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Jan 9, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners January 9, 2020 08:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2020
@crisbeto
build: bump Angular dependencies to latest versions
f4b8f8e 
Bumps the Angular-related dependencies to their latest versions.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 9, 2020
@crisbeto
Copy link
Member Author

crisbeto commented Jan 9, 2020

Bumping to a P2, because it caused a change in all the golden files (quotes were changed) which has the potential for lots of merge conflicts.

devversion
devversion approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agreed that we should get it in as soon as possible.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2020
@mmalerba mmalerba merged commit 06dabae into angular:master Jan 9, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
build: bump Angular dependencies to latest versions (angular#18137)
a080e2b 
Bumps the Angular-related dependencies to their latest versions.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @jelbourn @googlebot @mmalerba