refactor(material): remove deprecated month constants from core #18111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
refactor/material-core-remove-month-constants
branch
from
216a608 to
4d90fbd
Compare
|
Note: Changing to |
jelbourn
approved these changes
Jan 9, 2020
jelbourn
added
blocked
devversion
force-pushed
the
refactor/material-core-remove-month-constants
branch
from
4d90fbd to
b338b61
Compare
devversion
added
action: merge
devversion
force-pushed
the
refactor/material-core-remove-month-constants
branch
from
b338b61 to
de0b396
Compare
jelbourn
added
P3
devversion
added
P2
In the past, we accidentally published the month constants in `@angular/material/core`. These were never intended for public consumption but were only needed for testing. In v7, we deprecated the constants (with the assumption that consumers might have used constants). Now, we can remove the constants. There is no replacement for these variables. Instead, use the zero-based month index on your own. BREAKING CHANGE: Deprecated month constants from `@angular/material/core` have been removed. These have been accidentally published in the past while they were only intended for internal consumption in tests.
devversion
force-pushed
the
refactor/material-core-remove-month-constants
branch
from
de0b396 to
2e4703f
Compare
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Sep 5, 2020
In the past, we accidentally published the month constants in `@angular/material/core`. These were never intended for public consumption but were only needed for testing. In v7, we deprecated the constants (with the assumption that consumers might have used constants). Now, we can remove the constants. There is no replacement for these variables. Instead, use the zero-based month index on your own. BREAKING CHANGE: Deprecated month constants from `@angular/material/core` have been removed. These have been accidentally published in the past while they were only intended for internal consumption in tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we accidentally published the month constants in
@angular/material/core. These were never intended for publicconsumption but were only needed for testing. In v7, we deprecated
the constants (with the assumption that consumers might have used constants).
Now, we can remove the constants now. There is no replacement for these
variables. Instead, use the zero-based month index on your own.
BREAKING CHANGE: Deprecated month constants from
@angular/material/corehave beenremoved. These have been accidentally published in the past while they
were only intended for internal consumption in tests.