fix(material-experimental/mdc-chips): removed chip still focusable #18083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an MDC chip is removed it gets transitioned to `width: 0`, but it's up to the consumer to remove it from the DOM. This means that it's possible for the user to tab into it. These changes add `display: none` after the animation is done so the element becomes non-focusable.
crisbeto
added
pr: merge safe
P4
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
LGTM, not merge safe though, since this is used internally |
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…lar#18083) When an MDC chip is removed it gets transitioned to `width: 0`, but it's up to the consumer to remove it from the DOM. This means that it's possible for the user to tab into it. These changes add `display: none` after the animation is done so the element becomes non-focusable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an MDC chip is removed it gets transitioned to
width: 0, but it's up to the consumer to remove it from the DOM. This means that it's possible for the user to tab into it. These changes adddisplay: noneafter the animation is done so the element becomes non-focusable.