Skip to content

build: disallow usages of the first operator #17836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

build: disallow usages of the first operator #17836

merged 1 commit into from
Nov 28, 2019

Conversation

crisbeto
Copy link
Member

The first operator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages to take(1), but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.

@crisbeto
build: disallow usages of the first operator
35aeb2f 
The `first` operator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages to `take(1)`, but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 28, 2019
@crisbeto crisbeto requested review from jelbourn and a team as code owners November 28, 2019 14:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 28, 2019
jelbourn
jelbourn approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 28, 2019
@jelbourn jelbourn merged commit d4a2a0c into angular:master Nov 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot