Skip to content

chore: mark all packages as sideEffects: false #17686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

chore: mark all packages as sideEffects: false #17686

merged 1 commit into from
Nov 13, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 12, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2019
devversion
devversion approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume the property just got lost when we created new packages. Since we do not have any top-level file side-effects it should not be a problem to set sideEffects to false.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 13, 2019
@mmalerba mmalerba merged commit 2b02cc3 into angular:master Nov 13, 2019
@mmalerba mmalerba deleted the no-side-effect branch November 13, 2019 18:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @devversion @jelbourn @googlebot