build: enable bazel node modules symlinking #17675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Enables bazel managed node modules symlinking (similar to what framework does). We benefit from: * Easier way to make manual changes to debug issues * Less disk size since we do not need to maintain two instances of `node_modules` * Caching of node modules in CI. Bazel previously discarded the whole node modules folder if the lock file changed.
devversion
force-pushed
the
build/enable-node-modules-symlinking
branch
from
1f8f19f to
02a8a9f
Compare
devversion
added
pr: merge safe
target: patch
josephperrott
added
pr: lgtm
action: merge
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
Nov 21, 2019
This reverts commit 022acf8. Reverting this fixed the npm package build being broken.
mmalerba
pushed a commit
that referenced
this pull request
Nov 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables bazel managed node modules symlinking (similar to what framework does)
node_modulesmodules folder if the lock file changed.
Note: The postinstall patches script had to be updated to cover the following cases:
node_modules(i.e. from cache)