build: switch mdc snapshot test to run against master branch #17652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently run the MDC snapshot tests against their `develop` branch. This breaks at the moment since MDC deleted the branch in order to release a new major version. It's unclear what Git process they use, but considering they use Gitflow, then the `develop` branch should have not been deleted. This would be ideal for us.. because then we can just _always_ run against `develop`. For now though, since the branch does not exist anymore, we should switch to master so that the CI job can be green.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run the MDC snapshot tests against their
developbranch. This breaks at the moment since MDC deleted the branch
in order to release a new major version.
It's unclear what Git process they use, but considering they use
Gitflow, then the
developbranch should have not been deleted. Thiswould be ideal for us.. because then we can just always run against
develop.For now though, since the branch does not exist anymore, we should
switch to master so that the CI job can be green.