build: update goldens to ngtsc output #17605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
We should update our API goldens to be based on the ngtsc output. This helps us speeding up development since we don't need to build the packages with NGC whenever we want to update a golden (cache is usually ngtsc now since it's the default) One could argue that we do not want to have the definition members in the goldens, but we already do have private members in there too (due to how ts-api-guardian works). It technically is also correct to have the definition members in there since selectors, inputs are part of the public API.
devversion
force-pushed
the
build/update-goldens-for-ivy
branch
from
77b6524 to
a5d67c0
Compare
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
mmalerba and
a team
as code owners
devversion
added
pr: merge safe
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update our API goldens to be based on the
ngtsc output. This helps us speeding up development
since we don't need to build the packages with NGC
whenever we want to update a golden (cache is usually
ngtsc now since it's the default)
One could argue that we do not want to have the definition
members in the goldens, but we already do have private members
in there too (due to how ts-api-guardian works). It technically
is also correct to have the definition members in there since
selectors, inputs are part of the public API.