Skip to content

fix(block-scroll-strategy): don't overwrite scrollBehavior #17604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(block-scroll-strategy): don't overwrite scrollBehavior #17604

wants to merge 1 commit into from

Conversation

toxik
Copy link

@toxik toxik commented Nov 4, 2019

for browsers that don't support the method scrollTo (IE, Edge)
we need to leave the property scrollBehavior undefined, as it
interferes with the feature detection in scrolling.ts - supportsScrollBehavior

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Nov 4, 2019
@toxik
Copy link
Author

toxik commented Nov 4, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 4, 2019
for browsers that don't support the method scrollTo (IE, Edge)
we need to leave the property scrollBehavior undefined, as it
interferes with the feature detection in scrolling.ts - supportsScrollBehavior
@crisbeto
Copy link
Member

crisbeto commented Nov 4, 2019

There's a fix for this already at #17223.

@toxik
Copy link
Author

toxik commented Nov 4, 2019

thanks @crisbeto, closing this then.

@toxik toxik closed this Nov 4, 2019
@toxik toxik deleted the fix/block-scroll-strategy branch November 4, 2019 16:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants