-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Use MatDateSelectionModel to model the selected value in MatDatepickerInput #17497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MatDateSelectionModel to model the selected value in MatDatepickerInput #17497
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the commit description reflective of what is actually happening in the commit, e.g. "Use MatDateSelectionModel
to model the selected value in MatDatepickerInput
"
dff1c3f
to
a600bf7
Compare
a600bf7
to
6422dfc
Compare
This looks good to me aside from the one comment above, and the fact that CI is red. You can run the following command to fix the api_golden_checks: |
6422dfc
to
025613a
Compare
025613a
to
56206f3
Compare
The renaming CI failure is definitely a flake or existing issue, this PR does not affect the mat-menu. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We had to change one test in order to pass. Please take a look if the change is ok or if other changes would be required.