Skip to content

Use MatDateSelectionModel to model the selected value in MatDatepickerInput #17497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jaguima
Copy link
Contributor

@jaguima jaguima commented Oct 24, 2019

We had to change one test in order to pass. Please take a look if the change is ok or if other changes would be required.

@jaguima jaguima requested a review from mmalerba as a code owner October 24, 2019 20:05
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 24, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 24, 2019
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the commit description reflective of what is actually happening in the commit, e.g. "Use MatDateSelectionModel to model the selected value in MatDatepickerInput"

@jaguima jaguima force-pushed the jaguima-date-selection-model branch from dff1c3f to a600bf7 Compare November 4, 2019 22:31
@jaguima jaguima force-pushed the jaguima-date-selection-model branch from a600bf7 to 6422dfc Compare November 11, 2019 22:09
@mmalerba mmalerba changed the title Refactored date picker Use MatDateSelectionModel to model the selected value in MatDatepickerInput Nov 11, 2019
@mmalerba
Copy link
Contributor

This looks good to me aside from the one comment above, and the fact that CI is red. You can run the following command to fix the api_golden_checks: bazel run //tools/public_api_guard:material/core.d.ts_api.accept, I think the other failure might just be a flake

@jaguima jaguima force-pushed the jaguima-date-selection-model branch from 6422dfc to 025613a Compare November 11, 2019 23:03
@jaguima jaguima requested a review from jelbourn as a code owner November 11, 2019 23:03
@jaguima jaguima force-pushed the jaguima-date-selection-model branch from 025613a to 56206f3 Compare November 11, 2019 23:08
@mmalerba
Copy link
Contributor

The renaming CI failure is definitely a flake or existing issue, this PR does not affect the mat-menu.

@mmalerba mmalerba merged commit dc42988 into angular:date-selection-model Nov 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants