-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to latest Angular version #17389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps all of the Angular dependencies to the their latest versions since we were a few versions behind. Also fixes a usage of a deprecated method in a schematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but added a couple more possible updates
"@angular/core": "^9.0.0-next.10", | ||
"@angular/elements": "^9.0.0-next.10", | ||
"@angular/forms": "^9.0.0-next.10", | ||
"@angular/platform-browser": "^9.0.0-next.10", | ||
"@types/googlemaps": "^3.37.0", | ||
"@types/youtube": "^0.0.38", | ||
"@webcomponents/custom-elements": "^1.1.0", | ||
"core-js": "^2.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this can go to ^2.6.9
"@types/googlemaps": "^3.37.0", | ||
"@types/youtube": "^0.0.38", | ||
"@webcomponents/custom-elements": "^1.1.0", | ||
"core-js": "^2.6.1", | ||
"material-components-web": "^4.0.0-canary.e851d4f40.0", | ||
"rxjs": "^6.5.2", | ||
"rxjs": "^6.5.3", | ||
"systemjs": "0.19.43", | ||
"tsickle": "^0.35.0", | ||
"tslib": "^1.9.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this can go to ^1.10.0
@@ -77,7 +77,7 @@ | |||
"@bazel/protractor": "^0.38.3", | |||
"@firebase/app-types": "^0.3.2", | |||
"@octokit/rest": "^16.28.7", | |||
"@schematics/angular": "^9.0.0-next.5", | |||
"@schematics/angular": "^9.0.0-next.9", | |||
"@types/browser-sync": "^2.26.1", | |||
"@types/fs-extra": "^4.0.3", | |||
"@types/glob": "^5.0.33", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codelyzer, firebase-tools, and tslint can be bumped as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Those other packages can be updated separately
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bumps all of the Angular dependencies to the their latest versions since we were a few versions behind. Also fixes a usage of a deprecated method in a schematic.