Skip to content

feat(material/menu/testing): finish implementing harness #17379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

feat(material/menu/testing): finish implementing harness #17379

merged 2 commits into from
Oct 15, 2019

Conversation

mmalerba
Copy link
Contributor

currently blocked on #17365

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful blocked This issue is blocked by some external factor, such as a prerequisite PR target: major This PR is targeted for the next major release labels Oct 11, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Oct 11, 2019
@mmalerba mmalerba requested review from jelbourn and crisbeto October 11, 2019 22:18
@mmalerba mmalerba requested a review from devversion as a code owner October 11, 2019 22:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2019
jelbourn
jelbourn approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba force-pushed the menu-harness-polish branch from 57e698b to eb72bde Compare October 12, 2019 00:50
@mmalerba mmalerba requested a review from a team as a code owner October 12, 2019 22:38
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe and removed blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe labels Oct 15, 2019
@mmalerba mmalerba force-pushed the menu-harness-polish branch from e27bbfb to f5cf8de Compare October 15, 2019 19:01
@mmalerba mmalerba merged commit aa2cbf7 into angular:master Oct 15, 2019
@mmalerba mmalerba deleted the menu-harness-polish branch October 15, 2019 21:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @googlebot