Skip to content

chore: update to nodejs rules 0.38.3 #17376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

gregmagolan
Copy link
Contributor

One more update to get angular/angular#33073 in as we moved the providers used by Angular to a common load location at //:providers.bzl

@gregmagolan gregmagolan requested review from jelbourn and a team as code owners October 11, 2019 18:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Don't we need to update the patch to reflect the new imports from providers.bzl?

@gregmagolan
Copy link
Contributor Author

LGTM in general. Don't we need to update the patch to reflect the new imports from providers.bzl?

Nope. There are legacy load locations still there for now and we'll just remove the patch after the changes land in angular and this repo updates to the next @angular/bazel

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 11, 2019
@jelbourn jelbourn merged commit d4bf7be into angular:master Oct 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants