fix(tabs): not picking up indirect descendant tabs in ivy #17346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P1
googlebot
added
the
cla: yes
crisbeto
commented
Oct 9, 2019
| @@ -243,11 +248,26 @@ export abstract class _MatTabGroupBase extends _MatTabGroupMixinBase implements | |||
| } | |||
| } | |||
|
|
|||
| this._subscribeToTabLabels(); | |||
There was a problem hiding this comment.
I removed this call because I noticed that there's another one just like it a few lines above. It seems like an issue when resolving merge conflicts.
crisbeto
force-pushed
the
17336/tabs-descendants-ivy
branch
from
e90b623 to
1e2a8fc
Compare
Splaktar
approved these changes
Oct 10, 2019
| </mat-tab-group> | ||
| `, | ||
| }) | ||
| class TabGroupWithIndirectDescendantTabs { |
There was a problem hiding this comment.
This is all duplicated from what's in material/. Do we have a reason for choosing this approach?
Was it too much work or is there a blocker to trying to export something from material/ tests that could be re-used in the material-experimental/mdc-x tests?
In ViewEngine `ContentChildren` would pick up indirect descendant items, as long as another directive wasn't matched along the way. This allowed for tabs to be wrapped inside something like an `ng-container`. With Ivy `ContentChildren` is a little more strict and it only works on direct descendants. These changes turn on `descendants` so that we continue supporting the existing use cases from ViewEngine. Note that it needs a bit of extra logic in order to ensure that nested tab groups continue to work as expected. Fixes angular#17336.
crisbeto
force-pushed
the
17336/tabs-descendants-ivy
branch
from
1e2a8fc to
ef1c63f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ViewEngine
ContentChildrenwould pick up indirect descendant items, as long as another directive wasn't matched along the way. This allowed for tabs to be wrapped inside something like anng-container. With IvyContentChildrenis a little more strict and it only works on direct descendants.These changes turn on
descendantsso that we continue supporting the existing use cases from ViewEngine. Note that it needs a bit of extra logic in order to ensure that nested tab groups continue to work as expected.Fixes #17336.