Skip to content

build: changelog should not show changes to google-maps #17313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We don't release the google-maps package and disabled the
package group in the changelog. Apparently there is a bug where
we do not detect commits as google-maps changes if the commit
format does not specify an explicit package, but rather just a scope.

We usually determine the package based on the scope by looking
for matching packages. This did not work for google-maps changes
such as 30de283

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 7, 2019
@devversion devversion requested a review from a team as a code owner October 7, 2019 07:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 7, 2019
We don't release the google-maps package and disabled the
package group in the changelog. Apparently there is a bug where
we do not detect commits as google-maps changes if the commit
format does not specify an explicit package, but rather just a scope.

We usually determine the package based on the scope by looking
for matching packages. This did not work for `google-maps` changes
such as 30de283
@devversion devversion force-pushed the build/changelog-do-not-show-google-maps branch from 633a1e5 to 75c9869 Compare October 7, 2019 08:11
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 7, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 45a4300 into angular:master Oct 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants