build: fix docs-content release output #17125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Fixes the missing metadata for example modules. This happens because we built the individual example modules without a flat module bundle. Not building with a flat module bundle means that metadata will not be generated in the `ng_module` bazel rule.
Applies a workaround for the invalid imports generation issue in the Bazel `ng_module` rule. Read more about this here: https://hackmd.io/@devversion/ryCOwIKIS.
This is necessary as `ng_module` rules with a `module_name` either need a `public-api.ts` or `module.ts` file.
devversion
force-pushed
the
build/docs-content-metadata
branch
from
5bb4a2f to
2727e4b
Compare
Apparently the `google-maps` package has the same problem as the `material-examples` package where the metadata for the Bazel sub-packages is not incldued in the entry-point of the `@angular/google-maps` entry-point. There are two solutions to make it work with Angular package format: * Making the packages generate flat module bundles and including them as secondary entry-points * Only having one Bazel package so that metadata will be included in the flat module bundle. I chose the latter as the `google-maps` package is still very small and doesn't have a lot of dependencies, so in terms of speed it is even faster to have on package. Also it seems like there were never plans to have secondary entry-points for that package. *Note*: we need this commit as part of the docs-content fix because the google-maps package runs on CI and will fail as it misses various `public-api.ts` files for the flat module bundles.
Looks like a few examples were missing the `MatButtonModule` after the restructuring of the examples. I've noticed these while manually testing the Bazel release output in the docs app.
We no longer can build the examples package through gulp. This is because we did not add individual `tsconfig-build.json` files to the nested entry-points when we did the restructuring of the examples. This now breaks as the primary entry-point uses module name imports as of the docs-content metadata fix. It's okay to not build the examples package through gulp in the `8.2.x` branch as we don't need it in the gulp setup anyway.
|
Note: this should only o into the |
devversion
added
the
merge: caretaker note
|
Also note that there are a few CI checks which are actually removed, but still show up because they are marked as required in the Github UI. Maybe we can remove these for project health? |
devversion
requested review from
jelbourn,
mmalerba and
a team
as code owners
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #17046. Also includes #17126.