Skip to content

feat(dialog): move test harness out of experimental #17104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

feat(dialog): move test harness out of experimental #17104

merged 1 commit into from
Sep 17, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 17, 2019 •
edited
Loading

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Sep 17, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 17, 2019
@mmalerba mmalerba requested a review from jelbourn September 17, 2019 06:33
@mmalerba mmalerba requested review from crisbeto, devversion and a team as code owners September 17, 2019 06:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 17, 2019
crisbeto
crisbeto reviewed Sep 17, 2019
View reviewed changes
test/karma-system-config.js
@@ -112,6 +112,8 @@ System.config({
'@angular/material/core': 'dist/packages/material/core/index.js',
'@angular/material/datepicker': 'dist/packages/material/datepicker/index.js',
'@angular/material/dialog': 'dist/packages/material/dialog/index.js',
'@angular/material/dialog/testing': 'dist/packages/material/dialog/testing/index.js',
'@angular/material/dialog/testing/shared.spec': 'dist/packages/material/dialog/testing/shared.spec.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a little weird to import one test file into another? Instead we could do like we did for the component tests and copy them over. Compared to the component tests, the harness ones are fairly simple.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the components tests, there is a slight amount of variance between implementations. For these tests, though, we super want them to be exactly the same because it's part of our migration strategy (get people to use the harnesses, and then change the underlying implementation).

jelbourn
jelbourn approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 17, 2019
@ngbot
Copy link

ngbot bot commented Sep 17, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure conflicts with base branch "master"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 17, 2019
@mmalerba mmalerba merged commit 8859dfc into angular:master Sep 17, 2019
@mmalerba mmalerba deleted the mv-dialog-harness branch September 17, 2019 19:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @crisbeto @googlebot