Skip to content

build: group changelog entries by packages #17017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Resolves COMP-225

image

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 9, 2019
@devversion devversion requested a review from a team as a code owner September 9, 2019 15:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 9, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the commit messages need to look like with this?

@devversion devversion force-pushed the build/group-changelog-entries-by-packages branch from e816910 to c793718 Compare September 10, 2019 13:39
@devversion
Copy link
Member Author

@jelbourn I've updated the CONTRIBUTING.md file as part of this PR. That should make it clear what commit format we expect. This matches the format we already used for cdk-experimental and material-experimental changes.

If we decide to go with this, I'd propose that we also lint the commit message similarly to how it is done in angular/angular.

Exclude google-maps package from changelog
@josephperrott
Copy link
Member

I think that regardless of what changes we make in CHANGELOG we should begin linting commit messages

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 10, 2019
@jelbourn jelbourn merged commit 4fe5758 into angular:master Sep 10, 2019
jelbourn pushed a commit that referenced this pull request Sep 10, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants