Skip to content

feat(core): allow more granular control over sanity checks #16973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 4, 2019

Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment.

Fixes #16617.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release labels Sep 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 4, 2019
@crisbeto crisbeto force-pushed the 16617/granular-sanity-checks branch from ef772ea to 7a0d5bc Compare September 4, 2019 19:35
@crisbeto crisbeto force-pushed the 16617/granular-sanity-checks branch from 7a0d5bc to 47ade95 Compare September 4, 2019 20:42
@crisbeto crisbeto force-pushed the 16617/granular-sanity-checks branch 2 times, most recently from 74063c8 to 11b09f2 Compare September 5, 2019 19:44
@crisbeto
Copy link
Member Author

crisbeto commented Sep 5, 2019

Reworked based on the feedback @jelbourn.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2019
@ngbot
Copy link

ngbot bot commented Sep 5, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment.

Fixes angular#16617.
@crisbeto crisbeto force-pushed the 16617/granular-sanity-checks branch from 11b09f2 to b016497 Compare September 7, 2019 14:31
@jelbourn jelbourn merged commit 77994e9 into angular:master Sep 16, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Itemize sanity checks
4 participants