feat(cdk-experimental/testing): Add a public stabilize method to TestElement #16847
Conversation
mmalerba
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
| * In most cases it should not be necessary to call this. However, there may be some edge cases | ||
| * where it is needed to fully flush animation events. | ||
| */ | ||
| stabilize(): Promise<void>; |
There was a problem hiding this comment.
Any naming preference? I could also see flush
There was a problem hiding this comment.
Maybe whenStable to match the one on the ComponentFixture? I don't have a strong preference either.
There was a problem hiding this comment.
We chatted and Miles suggested forceStabilize which I really like because it has a built in discouragement from using when its not necessary
| * In most cases it should not be necessary to call this. However, there may be some edge cases | ||
| * where it is needed to fully flush animation events. | ||
| */ | ||
| stabilize(): Promise<void>; |
There was a problem hiding this comment.
Maybe whenStable to match the one on the ComponentFixture? I don't have a strong preference either.
mmalerba
force-pushed
the
harness-stabilize
branch
from
a70bf21 to
36d7cef
Compare
mmalerba
added
the
P2
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.