Skip to content

build: run snapshot local browser tests with bazel #16832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Runs the snapshot local browser tests with Bazel. This improves
our consistency and allows us to remove gulp test in the future.

@devversion devversion requested a review from jelbourn as a code owner August 21, 2019 10:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2019
@devversion devversion force-pushed the build/fix-snapshot-local-browsers-test branch 2 times, most recently from 1a8d685 to e1f015d Compare August 21, 2019 10:48
Runs the snapshot local browser tests with Bazel. This improves
our consistency and allows us to remove `gulp test` in the future.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 21, 2019
@devversion devversion force-pushed the build/fix-snapshot-local-browsers-test branch from e1f015d to 2dbf1bd Compare August 21, 2019 12:19
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2019
@jelbourn jelbourn merged commit 9661530 into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
Runs the snapshot local browser tests with Bazel. This improves
our consistency and allows us to remove `gulp test` in the future.

(cherry picked from commit 9661530)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants