build: switch test targets to karma_web_test_suite #16818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
CI failures look related? |
|
@jelbourn Yeah, I wanted to get back to fix these, but got stuck on restructuring the examples. will let you know when this is ready. |
devversion
force-pushed
the
build/switch-to-karma-web-test-suite
branch
from
357b7e9 to
afa8f21
Compare
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363.
devversion
force-pushed
the
build/switch-to-karma-web-test-suite
branch
from
afa8f21 to
29ceb2b
Compare
devversion
added
pr: merge safe
and removed
in progress
|
@jelbourn PR is ready for review now. |
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
Switches all `ts_web_test_suite` targets to the new `karma_web_test_suite` rule. `ts_web_test_suite` is based on the `karma_web_test_suite` rule but does not allow developers to have a custom karma configuration. In order to be able to provide a custom karma configuration for setting up Saucelabs and Browserstack, we switch all targets over to the `karma_web_test_suite` rule. See: bazelbuild/rules_typescript#363. (cherry picked from commit c791926)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all
ts_web_test_suitetargets to the newkarma_web_test_suiterule.ts_web_test_suiteisbased on the
karma_web_test_suiterule but does notallow developers to have a custom karma configuration.
In order to be able to provide a custom karma configuration
for setting up Saucelabs and Browserstack, we switch all
targets over to the
karma_web_test_suiterule.See: bazelbuild/rules_typescript#363.
@josephperrott I don't think we want to provide a custom karma configuration for all targets right now. Only the target that runs on Saucelabs should provide the custom karma configuration. We prospectively will have targets that combine multiple tests to avoid rate and browser limits.
Ideally even then, we would not need to specify a custom karma configuration as the default karma configuration for Bazel has an integrated mechanism for using saucelabs. see:
https://github.com/bazelbuild/rules_nodejs/blob/master/packages/karma/src/karma.conf.js#L311