Skip to content

build: update rules sass version #16812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

devversion
Copy link
Member

Updates the version of rules_sass and enables worker
compilation. Sass compilation actions were generally a
pain-point within the current Bazel pipeline, but the
workers fix this bottleneck.

Updates the version of `rules_sass` and enables worker
compilation. Sass compilation actions were generally a
pain-point within the current Bazel pipeline, but the
workers fix this bottleneck.
@devversion devversion requested a review from jelbourn as a code owner August 19, 2019 07:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2019
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 19, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 19, 2019
@jelbourn jelbourn merged commit 5e0b8ec into angular:master Aug 19, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
Updates the version of `rules_sass` and enables worker
compilation. Sass compilation actions were generally a
pain-point within the current Bazel pipeline, but the
workers fix this bottleneck.

(cherry picked from commit 5e0b8ec)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants