fix(schematics): module imports not generated for schematics #16787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in some scenarios the CLI project has a different TypeScript version than the `typescript` version used in the `@schematics/angular` package. This causes AST parsing & transformations to be broken due to the shifted values (e.g. in the `SyntaxKind` enum). Previously we solved this by always using the `typescript` version brought in by the `@schematics/angular` package, but this no longer works as of v8.0.0 CLI because the `@schematics/angular` package now vendors `typescript` instead of having an explicit version as dependency. angular/angular-cli@bf1c069
devversion
added
P2
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
Currently in some scenarios the CLI project has a different TypeScript version than the `typescript` version used in the `@schematics/angular` package. This causes AST parsing & transformations to be broken due to the shifted values (e.g. in the `SyntaxKind` enum). Previously we solved this by always using the `typescript` version brought in by the `@schematics/angular` package, but this no longer works as of v8.0.0 CLI because the `@schematics/angular` package now vendors `typescript` instead of having an explicit version as dependency. angular/angular-cli@bf1c069 (cherry picked from commit 6275b49)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in some scenarios the CLI project has a different TypeScript version
than the
typescriptversion used in the@schematics/angularpackage.This causes AST parsing & transformations to be broken due to the shifted
values (e.g. in the
SyntaxKindenum). Previously we solved this by alwaysusing the
typescriptversion brought in by the@schematics/angularpackage,but this no longer works as of v8.0.0 CLI because the
@schematics/angularpackage now vendors
typescriptinstead of having an explicit version asdependency.
angular/angular-cli@bf1c069