Skip to content

feat(youtube-player): Wire up start/end seconds and suggested quality… #16736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

YourDeveloperFriend
Copy link
Collaborator

… as inputs

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 9, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm target: minor This PR is targeted for the next minor release labels Aug 13, 2019
@jelbourn
Copy link
Member

Just needs a rebase based on other PRs being merged

@YourDeveloperFriend YourDeveloperFriend force-pushed the extraneous branch 3 times, most recently from ff8e926 to 9261d34 Compare August 16, 2019 20:21
@YourDeveloperFriend
Copy link
Collaborator Author

PR is ready for review. Can we rerun the test that failed? It doesn't seem related to this PR.

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe and removed pr: needs rebase labels Aug 19, 2019
@ngbot
Copy link

ngbot bot commented Aug 19, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_local_browsers" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

Yeah, the failure is unrelated

@jelbourn jelbourn merged commit d5d7db4 into angular:master Aug 19, 2019
@YourDeveloperFriend YourDeveloperFriend deleted the extraneous branch August 19, 2019 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants