Skip to content

fix(drag-drop): not picking up initial disabled state of handle #16643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix(drag-drop): not picking up initial disabled state of handle #16643

merged 1 commit into from
Jan 27, 2020

Conversation

crisbeto
Copy link
Member

Fixes the CdkDrag directive not picking up the disabled state of a handle, if it was set before CdkDrag subscribed to its _stateChanges stream.

Fixes #16642.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 30, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2019
jelbourn
jelbourn approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2019
@crisbeto
fix(drag-drop): not picking up initial disabled state of handle
0e02605 
Fixes the `CdkDrag` directive not picking up the `disabled` state of a handle, if it was set before `CdkDrag` subscribed to its `_stateChanges` stream.

Fixes angular#16642.
@crisbeto crisbeto force-pushed the 16642/drag-drop-pre-disabled-handle branch from 6dbd9d4 to 0e02605 Compare November 2, 2019 12:45
@jelbourn jelbourn merged commit 0760454 into angular:master Jan 27, 2020
jelbourn pushed a commit that referenced this pull request Jan 27, 2020
@crisbeto @jelbourn
fix(drag-drop): not picking up initial disabled state of handle (#16643)
3b28d33 
Fixes the `CdkDrag` directive not picking up the `disabled` state of a handle, if it was set before `CdkDrag` subscribed to its `_stateChanges` stream.

Fixes #16642.

(cherry picked from commit 0760454)
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@crisbeto @yifange
fix(drag-drop): not picking up initial disabled state of handle (angu…
cf3f359 
…lar#16643)

Fixes the `CdkDrag` directive not picking up the `disabled` state of a handle, if it was set before `CdkDrag` subscribed to its `_stateChanges` stream.

Fixes angular#16642.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CdkDrag: cdkDragHandleDisabled does not work if it is set on component instantiation
3 participants
@crisbeto @jelbourn @googlebot