Skip to content

fix(tabs): tab nav bar not highlighting active tab if rendered after init #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

fix(tabs): tab nav bar not highlighting active tab if rendered after init #16624

merged 1 commit into from
Aug 27, 2019

Conversation

crisbeto
Copy link
Member

Fixes the mat-tab-nav-bar not aligning the ink bar to the active item, if the list of items comes in after the bar has been rendered.

Fixes #16607.

@crisbeto
fix(tabs): tab nav bar not highlighting active tab if rendered after …
0267578 
…init

Fixes the `mat-tab-nav-bar` not aligning the ink bar to the active item, if the list of items comes in after the bar has been rendered.

Fixes angular#16607.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 27, 2019
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 27, 2019 07:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2019
@crisbeto crisbeto mentioned this pull request Jul 27, 2019
Closed
jelbourn
jelbourn approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2019
@jelbourn jelbourn merged commit 93e9415 into angular:master Aug 27, 2019
mmalerba pushed a commit to mmalerba/components that referenced this pull request Aug 27, 2019
@crisbeto @mmalerba
fix(tabs): tab nav bar not highlighting active tab if rendered after …
8307ba7 
…init (angular#16624)

Fixes the `mat-tab-nav-bar` not aligning the ink bar to the active item, if the list of items comes in after the bar has been rendered.

Fixes angular#16607.
@crisbeto crisbeto mentioned this pull request Sep 4, 2019
Closed
@naveedahmed1
Copy link

I think this pull request has introduced this issue #17055

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatTabNavBar InkBar not showing active tab when rendered without data
5 participants
@crisbeto @naveedahmed1 @jelbourn @googlebot @andrewseguin