Skip to content

fix(popover-edit): blending in with background in high contrast mode #16604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix(popover-edit): blending in with background in high contrast mode #16604

merged 1 commit into from
Jul 24, 2019

Conversation

crisbeto
Copy link
Member

Fixes the popover edit's overlay blending in with the background in high contrast mode, because it doesn't have a border or an outline.

@crisbeto
fix(popover-edit): blending in with background in high contrast mode
66e138d 
Fixes the popover edit's overlay blending in with the background in high contrast mode, because it doesn't have a border or an outline.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 24, 2019
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 24, 2019 20:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 24, 2019
@kseamon
Copy link
Collaborator

kseamon commented Jul 24, 2019

LGTM

jelbourn
jelbourn approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2019
@jelbourn jelbourn merged commit b5b9ff7 into angular:master Jul 24, 2019
andrewseguin pushed a commit that referenced this pull request Jul 29, 2019
@crisbeto @andrewseguin
fix(popover-edit): blending in with background in high contrast mode (#…
3119763 
…16604)

Fixes the popover edit's overlay blending in with the background in high contrast mode, because it doesn't have a border or an outline.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @kseamon @jelbourn @googlebot