Skip to content

docs(dialog): move up entry components section #16575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 15, 2019
Merged

docs(dialog): move up entry components section #16575

merged 1 commit into from Aug 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2019

To use components within a dialog, the entryComponents configuration is required. The section documenting how it works should move up to a spot closer to the top of the page. I saw a few bugs reported and a few stackoverflow questions related to this.

@ghost ghost requested review from crisbeto and jelbourn as code owners July 20, 2019 20:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this won't be an issue with Ivy anymore.

@crisbeto crisbeto added docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 15, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit d579537 into angular:master Aug 15, 2019
@ghost ghost deleted the docs-dialog-entry-components-section branch August 16, 2019 00:03
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants