fix(menu): mark lazy menu content as dirty before attach #16506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
approved these changes
Jul 11, 2019
src/material/menu/menu-content.ts
Outdated
| @@ -39,7 +40,8 @@ export class MatMenuContent implements OnDestroy { | |||
| private _appRef: ApplicationRef, | |||
| private _injector: Injector, | |||
| private _viewContainerRef: ViewContainerRef, | |||
| @Inject(DOCUMENT) private _document: any) {} | |||
| @Inject(DOCUMENT) private _document: any, | |||
| private _changeDetectorRef: ChangeDetectorRef) {} | |||
There was a problem hiding this comment.
_changeDetectorRef should be marked as optional?
jelbourn
force-pushed
the
menu-onpush-content-fix
branch
2 times, most recently
from
b3c0d67 to
8c039f4
Compare
crisbeto
approved these changes
Jul 12, 2019
src/material/menu/menu-content.ts
Outdated
| @@ -39,7 +41,8 @@ export class MatMenuContent implements OnDestroy { | |||
| private _appRef: ApplicationRef, | |||
| private _injector: Injector, | |||
| private _viewContainerRef: ViewContainerRef, | |||
| @Inject(DOCUMENT) private _document: any) {} | |||
| @Inject(DOCUMENT) private _document: any, | |||
| @Optional() private _changeDetectorRef: ChangeDetectorRef) {} | |||
There was a problem hiding this comment.
The @Optional won't help with backwards compatibility. It should be marked as an optional parameter (_changeDetectorRef?: ChangeDetectorRef). Also I think we can drop the @Optional since we'll always have a ChangeDetectorRef.
jelbourn
force-pushed
the
menu-onpush-content-fix
branch
2 times, most recently
from
61d23b2 to
1203427
Compare
jelbourn
added
action: merge
This fixes a Google presubmit issue where the menu's `@ContentChildren` aren't updated after attaching lazy `MatMenuContent`.
jelbourn
force-pushed
the
menu-onpush-content-fix
branch
from
1203427 to
6ccf235
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
This fixes a Google presubmit issue where the menu's `@ContentChildren` aren't updated after attaching lazy `MatMenuContent`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a Google presubmit issue where the menu's
@ContentChildrenaren't updated after attaching lazy
MatMenuContent.