Skip to content

test(grid-list): disable flaky tests in Edge #16504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

test(grid-list): disable flaky tests in Edge #16504

merged 1 commit into from
Jul 11, 2019

Conversation

crisbeto
Copy link
Member

Disables some tests that have become so flaky that they aren't very useful in Edge.

@crisbeto
test(grid-list): disable flaky tests in Edge
2372555 
Disables some tests that have become so flaky that they aren't very useful in Edge.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 11, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner July 11, 2019 20:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2019
@devversion
Copy link
Member

Should we create a JIRA ticket to consider re-enabling those if we ever update the Edge version?

jelbourn
jelbourn approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 11, 2019
@jelbourn jelbourn merged commit bb7af77 into angular:master Jul 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @jelbourn @googlebot