fix(ng-update): do not rely on node-glob for finding rule directories #16381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use `glob` in order to find rule directories automatically. This has implications because it means that we depend on `glob` that is usually brought in transitively by other project dependencies. This means that the glob version is not guaranteed to be working due to previous `glob` issues on windows. Related to angular#16208
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jul 2, 2019
…#16381) We currently use `glob` in order to find rule directories automatically. This has implications because it means that we depend on `glob` that is usually brought in transitively by other project dependencies. This means that the glob version is not guaranteed to be working due to previous `glob` issues on windows. Related to #16208
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
globin order to find rule directories automatically. Thishas implications because it means that we depend on
globthat is usuallybrought in transitively by other project dependencies. This means that the
glob version is not guaranteed to be working due to previous
globissues on windows.
Related to #16208