build: create script for setting up RBE in local dev environment #16375
Conversation
josephperrott
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
| # Determine the root directory of the Angular github repo. | ||
| GITHUB_DIRECTORY_ROOT=$(git rev-parse --show-toplevel 2> /dev/null); | ||
| if [[ $? -ne 0 ]]; then | ||
| echo "This command must be run from within the angular repository." |
There was a problem hiding this comment.
| echo "This command must be run from within the angular repository." | |
| echo "This command must be run from within the cloned \"angular/components\" repository." |
|
|
||
| # Confirm the parameter provided to the script is a directory | ||
| if [[ ! -d $1 ]]; then | ||
| echo "The paramter provided is not a directory"; |
There was a problem hiding this comment.
There is a typo for parameter here. How about showing the usage instead? Maybe also expand on why we need to even specify a directory.
| echo "The paramter provided is not a directory"; | |
| echo "Invalid command syntax. Usage: ./script.sh <ServiceAccountKeyLocation>"; |
| echo "The paramter provided is not a directory"; | ||
| exit 1; | ||
| fi | ||
| ABSOLUTE_DIRECTORY_PATH=$(readlink -f $1) |
There was a problem hiding this comment.
Nit: For clarity I think the variable name should be named differently. Absolute directory path only describes the type but not what the variable contains.
There was a problem hiding this comment.
Yeah, I can see that, I tried something else. I can't come up with a good name so if you have any ideas let me know.
josephperrott
force-pushed
the
setup-local-rbe
branch
2 times, most recently
from
ef69bce to
def60fb
Compare
| # environment to use Remote Build Execution. | ||
|
|
||
| # Determine the root directory of the Angular github repo. | ||
| GITHUB_DIRECTORY_ROOT=$(git rev-parse --show-toplevel 2> /dev/null); |
There was a problem hiding this comment.
Prefer lower_case_snake_case for bash variables
|
|
||
| # Confirm gcloud installed and available as a command. | ||
| if [ ! -x "$(command -v gcloud)" ]; then | ||
| echo "gcloud command is not available. Please install gcloud before continuing." |
There was a problem hiding this comment.
Could this script install gcloud?
There was a problem hiding this comment.
We can't install gcloud because dependent on your platform we have to install it differently.
josephperrott
force-pushed
the
setup-local-rbe
branch
2 times, most recently
from
9e54d69 to
21c4a9c
Compare
josephperrott
force-pushed
the
setup-local-rbe
branch
from
21c4a9c to
88ed42a
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.