Skip to content

chore: add scaffolding for mdc-based tabs #16270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

crisbeto
Copy link
Member

Adds all of the scaffolding for the MDC-based tabs implementation.

Relates to #16250.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 11, 2019
@crisbeto crisbeto force-pushed the 16250/mdc-tabs-boilerplate branch 2 times, most recently from 08e7d7a to ef025cb Compare June 11, 2019 20:24
Adds all of the scaffolding for the MDC-based tabs implementation.

Relates to angular#16250.
@crisbeto crisbeto force-pushed the 16250/mdc-tabs-boilerplate branch from ef025cb to 750a8e1 Compare June 11, 2019 20:29
@crisbeto crisbeto marked this pull request as ready for review June 11, 2019 20:40
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 11, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 11, 2019
@ngbot
Copy link

ngbot bot commented Jun 11, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: e2e_tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit cfc3373 into angular:master Jun 11, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Adds all of the scaffolding for the MDC-based tabs implementation.

Relates to angular#16250.
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
Adds all of the scaffolding for the MDC-based tabs implementation.

Relates to #16250.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants