Skip to content

refactor(ng-generate): use .template suffix for schematic template files #16213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Switches all schematic template files to the .template file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to #16189

@devversion devversion requested a review from jelbourn as a code owner June 5, 2019 16:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2019
@devversion devversion force-pushed the refactor/ng-update-template-suffix-tmpl-files branch 2 times, most recently from 067dd19 to 6306e24 Compare June 5, 2019 17:19
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 5, 2019
@josephperrott
Copy link
Member

@devversion please rebase when you have a chance

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Jun 5, 2019
@devversion devversion force-pushed the refactor/ng-update-template-suffix-tmpl-files branch from 6306e24 to 4f8ed7b Compare June 6, 2019 08:20
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 6, 2019
@devversion
Copy link
Member Author

@josephperrott Done.

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
@devversion devversion force-pushed the refactor/ng-update-template-suffix-tmpl-files branch from 4f8ed7b to 698025f Compare June 6, 2019 17:49
@josephperrott josephperrott merged commit f6903da into angular:master Jun 7, 2019
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
…les (#16213)

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to #16189
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
…les (angular#16213)

Switches all schematic template files to the `.template` file extension. This
ensures that these files are not accidentally picked up in external
projects (e.g. when building the summary files with ngc).

Related to angular#16189
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants